Dereferencing Javascript Variables - Revisiting

Posted April 20, 2006 at 6:44 PM

Tags: Javascript / DHTML

As posted before I was having a very hard time getting dynamic onclick methods to call what I thought was a dereferenced variable. I was getting a lot of help and great suggestions on the CFTalk list, but one guy finally posted a link to:

http://calculist.blogspot.com/2005/12/gotcha-gotcha.html

This page discussed exactly the problem I was having, the reasons I was having it, and the solution. It's all about scoping of variables. The variable that I was alerting (in the dynamic onclick) was for the method (including every iteration of the FOR loop) and therefore each link pointed to it. In the solution below, the FOR loop is replaced with a repetative method call forces each variable scopes to be local.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Javascript Dynamic Variables</title>
<script type="text/javascript">

function TestClass( strName ){
this.Name = strName;
}

TestClass.prototype.AlertValue = function( anyValue ){
alert( this.Name + " is alerting: " + anyValue );
}


function Init(){
var objContentDiv = document.getElementById( "content" );
var objA = null;
var objTest = new TestClass( "Tester" );

// This runs the for loop using a LOCAL scope for each iteration.
(function loop( intI ){
var intX = intI;

if (intI < 10){

// Create new A element.
objA = document.createElement( "a" );

// Set A display properties.
objA.style.display = "block";
objA.style.backgroundColor = "#F8F8F8";
objA.style.border = "1px solid #333333";
objA.style.padding = "10px 10px 10px 10px";
objA.style.color = "#333333";
objA.style.marginBottom = "15px";

// Create text for the link.
objA.appendChild( document.createTextNode( "I should alert " + intX + " when clicked" ) );

// Set the href.
objA.setAttribute( "href", "##" );

// Set the onclick method.
objA.onclick = function(){ objTest.AlertValue( intX ) };

// Attach the A to the content.
objContentDiv.appendChild( objA );


loop(intI + 1);
}

})(0);

}


// Is the tester class available here (just testing).
alert( "objTest is of type: " + typeof(objTest));

</script>
</head>
<body onload="Init();">

<div id="content"></div>

</body>
</html>

Post Comment  |  Ask Ben  |  Other Searches  |  Print Page


You Might Also Be Interested In:



Learning ColdFusion 9 - ColdFusion 9 tutorials, samples, examples, demos

Reader Comments

Apr 3, 2007 at 9:16 AM // reply »
2 Comments

Hey thanks for this I'd be struggling with a similar problem all morning. JavaScript really is an ugly language, this solution seems a little strange but at least it works!


Apr 3, 2007 at 9:20 AM // reply »
7,501 Comments

@Pete,

I would recommend looking into jQuery. It is an awesome Javascript framework that I have just started working with. One of the things it provides is an Each() method (this is common to many Javascript frameworks). But anyway, because the Each() method takes a function literal, it forces you to create a new local scope for each loop iteration. This, in and of itself, helps take care of many of the "referencing" issues.


Apr 3, 2007 at 9:35 AM // reply »
2 Comments

Hi Ben,

I've been meaning to check out some of the JavaScript frameworks for sometime now. I will have a look into jQuery, I am told http://mootools.net is a good light weight framework.


Apr 3, 2007 at 9:37 AM // reply »
7,501 Comments

Yeah, I have heard good things about MooTools. If you are interested in some of my jQuery tinkerings:

http://www.bennadel.com/search/jquery


Post Comment  |  Ask Ben

Recent Blog Comments
Mar 15, 2010 at 1:26 PM
Finding The Distance Between Latitude / Longitude Locations In ColdFusion
as i said, "routing". googlemaps work well enough, even here in thailand. if that's not good enough & you have better transport infrastructure data (which is probably the only reason it's not "good ... read »
Mar 15, 2010 at 1:25 PM
Muscle: Confessions Of An Unlikely Bodybuilder By Samuel Wilson Fussell
It's been interesting reading some of the comments on Sam's book. Like Ben, I really appreciated his literary take on the subject of bodybuilding and his reasons for wanting to something more than a ... read »
Mar 15, 2010 at 1:09 PM
Your jQuery Selector Context Can Be A jQuery Object
@Karl, Ah, gotcha; yes you are making sense :) ... read »
Mar 15, 2010 at 1:03 PM
Your jQuery Selector Context Can Be A jQuery Object
@Ben, Yeah. By default, .live() binds events to document and uses event delegation to see if $(event.target).closest(selector) exists before executing your function. As of jQuery 1.4, you can s ... read »
Mar 15, 2010 at 12:52 PM
Finding The Distance Between Latitude / Longitude Locations In ColdFusion
@PaulH, These calcs are fine for flying city-to-city type long distance but does not help too much for driving distances. Any thoughts on driving distance between two geopoints? ... read »
Mar 15, 2010 at 12:50 PM
Your jQuery Selector Context Can Be A jQuery Object
@Karl, Is this for when it uses delegation? ... read »
Mar 15, 2010 at 12:49 PM
Google Maps Not Working in Internet Explorer (IE)
@Ralph, thanks in advance for the look at: http://76.12.123.25/asia/map/ ... read »
Mar 15, 2010 at 12:48 PM
Your jQuery Selector Context Can Be A jQuery Object
There is one case in which you need a DOM node as the "context" argument: when you're using it for the .live() method. Otherwise, you're right. ... read »